[webkit-reviews] review requested: [Bug 21475] Provide support for the Geolocation API : [Attachment 24463] updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 17 14:43:26 PDT 2008

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 21475: Provide support for the Geolocation API

Attachment 24463: updated

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
This addresses the items in Sam's review. Objects go through ::create() for
RefPtrs. Header order cleaned up. Doesn't add page to the back/forward cache if
it is currently using Geolocation (from IRC). stopsUpdating when
Geolocation::disconnectFrame is called. Copies data structures before iterating
(nice catch). 

The GeolocationServiceFake (and its tests) were removed from the patch. Having
geolocation be a property on Navigator only when in DRT has proven to be
complex. The test to verify that geolocation hasn't leaked into navigator is
some fashion is retained and more robust than the last patch.

I will file a followup bug for the GeolocationServiceFake implementation and

More information about the webkit-reviews mailing list