[webkit-reviews] review granted: [Bug 21407] Add a number of new layout tests, all passing on ToT : [Attachment 24460] Better XML declaration tests

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Pam Greene <pam at chromium.org>'s
request for review:
Bug 21407: Add a number of new layout tests, all passing on ToT
https://bugs.webkit.org/show_bug.cgi?id=21407

Attachment 24460: Better XML declaration tests
https://bugs.webkit.org/attachment.cgi?id=24460&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
It would be cool if the xml version was inside the html one (an iframe?), to
avoid having a mysterious test that has no explanation when opened in browser,
but only an error text. That would make it text-only, too.

Please add a bug reference and short explanation to the ChangeLog.

> fast/frames/crash-remove-onload-from-src.html

I think it's bug 18174, and Brady was going to land a test that covered it
according to a comment in that bug. So, the test can presumably be omitted.

> fast/xsl/xslt-nested-stylesheets.xml

This sounds like bug 15715, which is not fixed yet! The crash doesn't happen
with the versions of libxslt shipped by Apple, but the issue is still present.
Since the major block to landing a fix for bug 15715 was lack of a test case,
someone can probably finish it now.

r=me if you omit these two tests for now, and fix the ChangeLog. Please also
consider my comment about putting xml version of xml declaration test into an
iframe.