[webkit-reviews] review requested: [Bug 20760] Implement support for x86 Linux in CTI : [Attachment 24159] Enable SFX on Linux/GTK, updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 14:00:37 PDT 2008

Alp Toker <alp at nuanti.com> has asked  for review:
Bug 20760: Implement support for x86 Linux in CTI

Attachment 24159: Enable SFX on Linux/GTK, updated

------- Additional Comments from Alp Toker <alp at nuanti.com>
Now avoids duplication of CTI_ARGS.

-	 WRECFunction m_wrecFunction;
+	 void* m_wrecFunction;

You could put WRECFunction in its own header file but I'm not convinced it's
worth it. The way JITted code is passed around is probably going to have to
change soon anyway so splitting this typedef out into its own header will just
make more work. Besides, this pointer is invoked only in one place and is
mostly treated as data so the type safety argument seems bogus.

More information about the webkit-reviews mailing list