[webkit-reviews] review granted: [Bug 21433] Auto-generate the DOMDocument createNodeIterator: and createTreeWalker: methods : [Attachment 24152] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 14:00:22 PDT 2008


Sam Weinig <sam at webkit.org> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 21433: Auto-generate the DOMDocument createNodeIterator: and
createTreeWalker: methods
https://bugs.webkit.org/show_bug.cgi?id=21433

Attachment 24152: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=24152&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
+	 RetainPtr<id <DOMNodeFilter> > m_filter;
+    };
+
+} // namespace WebCore
+
+#endif

The #endif should have a comment. 

+#import "config.h"
+
+#include "ObjCNodeFilterCondition.h"
+
+#include "DOMNodeFilter.h"
+#include "DOMNodeInternal.h"
+#include "NodeFilter.h"
Shouldn't these all be #imports.

r=me


More information about the webkit-reviews mailing list