[webkit-reviews] review denied: [Bug 21407] Add a number of new layout tests, all passing on ToT : [Attachment 24118] 13 new layout tests, no results yet

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 7 09:58:12 PDT 2008


Darin Adler <darin at apple.com> has denied Pam Greene <pam at chromium.org>'s
request for review:
Bug 21407: Add a number of new layout tests, all passing on ToT
https://bugs.webkit.org/show_bug.cgi?id=21407

Attachment 24118: 13 new layout tests, no results yet
https://bugs.webkit.org/attachment.cgi?id=24118&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's great to have more tests! These look fine.

I'm not sure exactly why you posted this patch for review. If you want to get
the patch in the tree, then we need a patch that does include results; so I'll
say review- on that basis.

If you want a discussion of the merits of the individual tests, then you need a
patch with a smaller number of tests in it and some explanation of the
rationale behind the tests to attract an appropriate reviewer for each test.


More information about the webkit-reviews mailing list