[webkit-reviews] review denied: [Bug 20422] Patch to allow custom memory allocation control : [Attachment 24113] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kelemen Balázs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 20422: Patch to allow custom memory allocation control
https://bugs.webkit.org/show_bug.cgi?id=20422

Attachment 24113: proposed patch
https://bugs.webkit.org/attachment.cgi?id=24113&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This patch depends on Paul Pedriana's New.h, and if you read the bug report
you'll see many unaddressed comments from me about that. So we can't just land
that file until the comments are addressed. I'm not going to repeat my
comments.

This patch contains a double-copy of New.h; the whole file pasted twice. We
won't land that,

+	 HashEntry()
+		{
+			initialize(0, 0, 0, 0);
+		}

We don't want to add code like this. We need to fix AllocBase to eliminate that
spurious requirement rather than adding dead code to the project to work around
it.

-    class ExpressionNode : public Node {
+    class ExpressionNode : public Node, public WTF::AllocBase {

Where is the code that does "new ExpressionNode"?

+#include <wtf/New.h>

Why are you adding this include to ustring.h?

-    class Vector {
+    class Vector : public AllocBase {

Where is the code that does "new Vector"?

-class MainThreadInvoker : public QObject {
+class MainThreadInvoker : public QObject, public AllocBase {

Where is the code that does "new MainThreadInvoker"?