[webkit-reviews] review granted: [Bug 22564] Make HTML elements' constructors take a QualifiedName : [Attachment 25609] Proposed changes - First try

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22564: Make HTML elements' constructors take a QualifiedName
https://bugs.webkit.org/show_bug.cgi?id=22564

Attachment 25609: Proposed changes - First try
https://bugs.webkit.org/attachment.cgi?id=25609&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I find this pattern a bit strange:

     if (!MediaPlayer::isAvailable())
	 return new HTMLElement(tagName, doc);
-    return new HTMLVideoElement(doc);
+    return new HTMLVideoElement(videoTag, doc);

As antti pointed out before, that will break any uses of if
(element->hasTagName(videoTag) static_cast<HTMLVideoElement*>(element)...

Agreed, we should always be using something like element->isVideoElement()
instead.

The patch looks fine.