[webkit-reviews] review granted: [Bug 20340] SegmentedVector segment allocations can lead to unsafe use of temporary registers : [Attachment 25587] Proposed patch to change interface of SegmentedVector

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 20340: SegmentedVector segment allocations can lead to unsafe use of
temporary registers
https://bugs.webkit.org/show_bug.cgi?id=20340

Attachment 25587: Proposed patch to change interface of SegmentedVector
https://bugs.webkit.org/attachment.cgi?id=25587&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +	   void clear()
> +	   {
> +	       if (m_size != 0)
> +		   shrink(0);

It seem kind of silly to me to keep all the shrink logic just to handle
shrink(0).  We should either move the shrink logic that we need to clear.

Otherwise, r=me.