[webkit-reviews] review denied: [Bug 22460] Calls to console.trace() ASSERT due to JSFunction's incomplete inheritance chain : [Attachment 25439] Add InternalFunction as JSFunction's parent class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 18:00:40 PST 2008


Eric Seidel <eric at webkit.org> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 22460: Calls to console.trace() ASSERT due to JSFunction's incomplete
inheritance chain
https://bugs.webkit.org/show_bug.cgi?id=22460

Attachment 25439: Add InternalFunction as JSFunction's parent class
https://bugs.webkit.org/attachment.cgi?id=25439&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine, but should have a test case.  Is there no way to make a test case? 
Does console.trace() make no sense from within DRT?  If there is no reasonable
way to make a test case, you can consider this an r+.


More information about the webkit-reviews mailing list