[webkit-reviews] review denied: [Bug 22491] Add unit test skeleton for the WebKit/Gtk+ API : [Attachment 25493] Add unit test skeletong for WebKit/Gtk+

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 25 17:58:44 PST 2008


Eric Seidel <eric at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 22491: Add unit test skeleton for the WebKit/Gtk+ API
https://bugs.webkit.org/show_bug.cgi?id=22491

Attachment 25493: Add unit test skeletong for WebKit/Gtk+
https://bugs.webkit.org/attachment.cgi?id=25493&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems silly to add this w/o any test at all.  How do we know it works if it
doesn't actually test anything?  Also the pre 2.1.6 version shoudn't just
return 0, it should probably at least write a message to the console, no?  and
probably return 1?  Whatever tool is calling it should know the tests failed to
run because it was built with an old gtk, no?


More information about the webkit-reviews mailing list