[webkit-reviews] review denied: [Bug 22468] Coding style: config.h should only be included in implementation files, not in header : [Attachment 25509] Proposed addition: mostly made for discussion & enhancement

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22468: Coding style: config.h should only be included in implementation
files, not in header
https://bugs.webkit.org/show_bug.cgi?id=22468

Attachment 25509: Proposed addition: mostly made for discussion & enhancement
https://bugs.webkit.org/attachment.cgi?id=25509&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure it's clear to me from reading what an "implementation" file is. 
Maybe (.cpp, .c, .mm, etc.) as an aside would help.

This sentence is backwards:
This guarantees that each header's completeness is tested,
+to make sure it can be compiled without requiring any other header files be
+included first.

"This assures that each header can be compiled without requiring any other
header included first."  or similar, no need to state "completeness" and then
define it.

An extra wrong example of HTMLDivElement.h might be helpful.

Having HTMLDivElement.cpp unsorted might also be useful. :)

Otherwise looks fine.  This is a useful change to the style guide.