[webkit-reviews] review denied: [Bug 18830] Assertion failure (using HashMap empty value) in svg/W3C-SVG-1.1/fonts-glyph-02-t.svg : [Attachment 25224] Fix the calculation...

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 18830: Assertion failure (using HashMap empty value) in
svg/W3C-SVG-1.1/fonts-glyph-02-t.svg
https://bugs.webkit.org/show_bug.cgi?id=18830

Attachment 25224: Fix the calculation...
https://bugs.webkit.org/attachment.cgi?id=25224&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't understand this change.  Maybe mitz would.  It looks right, but I think
we could make this clearer using some local variable with clearer names.  Why
does all this need to be manual calculation?  Don't we have TextIterators or
similar for this kind of thing?

Here I'm going to be a hypocrit and mention there is not ChangeLog in this
patch.	:(  I know how much ChangeLogs suck with git... 

My approach here would be to start by cleaning up the code to the point where I
understood what it was doing... and then I would fix the bug.