[webkit-reviews] review granted: [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory : [Attachment 25453] Second Part - V2: Updated with Darin's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Julien Chaffraix
<jchaffraix at pleyo.com>'s request for review:
Bug 22441: Bridge the gap between the generated ElementFactory and
HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Attachment 25453: Second Part - V2: Updated with Darin's comments
https://bugs.webkit.org/attachment.cgi?id=25453&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -	   WebCore::Element* createElement(const WebCore::QualifiedName& qName,
WebCore::Document* doc, bool createdByParser = true);
> -	   static $parameters{'namespace'}Element*
create$parameters{'namespace'}Element(const WebCore::QualifiedName& qName,
WebCore::Document* doc, bool createdByParser = true);
> +	   PassRefPtr<Element> createElement(const WebCore::QualifiedName&,
WebCore::Document*, bool createdByParser = true);
> +	   static PassRefPtr<$parameters{'namespace'}Element>
create$parameters{'namespace'}Element(const WebCore::QualifiedName&,
WebCore::Document*, bool createdByParser = true);

I don't understand how you can change the declaration of the createElement
function here without also changing the return type in the definition of
createElement. I guess that's just a placeholder for the future.

r=me