[webkit-reviews] review requested: [Bug 22441] Bridge the gap between the generated ElementFactory and HTMLElementFactory : [Attachment 25453] Second Part - V2: Updated with Darin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 24 14:52:22 PST 2008


Julien Chaffraix <jchaffraix at pleyo.com> has asked  for review:
Bug 22441: Bridge the gap between the generated ElementFactory and
HTMLElementFactory
https://bugs.webkit.org/show_bug.cgi?id=22441

Attachment 25453: Second Part - V2: Updated with Darin's comments
https://bugs.webkit.org/attachment.cgi?id=25453&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at pleyo.com>
> These are all wrong and the patch should not be landed this way. We've
> discussed this many times in the past. But until now I didn't realize that
> <http://webkit.org/coding/coding-style.html> had this wrong.

That's quite bad as new people follow those instructions when they contribute
new code and they do not know the previous discussions. I have filed bug 22468
about this flaw in the documentation.


More information about the webkit-reviews mailing list