[webkit-reviews] review requested: [Bug 22448] Create an abstraction for JSC::SourceCode : [Attachment 25418] v1 patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 24 01:50:58 PST 2008
Darin Fisher (Google) <darin at chromium.org> has asked Sam Weinig
<sam at webkit.org> for review:
Bug 22448: Create an abstraction for JSC::SourceCode
https://bugs.webkit.org/show_bug.cgi?id=22448
Attachment 25418: v1 patch
https://bugs.webkit.org/attachment.cgi?id=25418&action=review
------- Additional Comments from Darin Fisher (Google) <darin at chromium.org>
Hi Sam, since you introduced JSC::SourceCode into WebCore, I thought I should
ask you to review this change.
>From the JSC perspective, I think this change is nice because it means that you
only need to include one header file (ScriptSourceCode.h) in order to get at
the two different ways of calling makeSource. I'm curious to know what you
think.
More information about the webkit-reviews
mailing list