[webkit-reviews] review granted: [Bug 22449] Implement repatching for get by id chain. : [Attachment 25417] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 24 01:50:46 PST 2008
Cameron Zwarich (cpst) <cwzwarich at uwaterloo.ca> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 22449: Implement repatching for get by id chain.
https://bugs.webkit.org/show_bug.cgi?id=22449
Attachment 25417: The patch
https://bugs.webkit.org/attachment.cgi?id=25417&action=review
------- Additional Comments from Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>
Add a reference to the bug number in the ChangeLog. I also think that an
explanation of the code changes in the ChangeLog would be nice as well.
> for (unsigned i = 0; i<count; ++i) {
There should be spaces on either side of '<'.
I prefer currentStructure to currStructure, but we use currStructure elsewhere,
so you might as well stick with it for this patch.
r=me
More information about the webkit-reviews
mailing list