[webkit-reviews] review requested: [Bug 22300] Use of NSCalibratedRGBColorSpace for CSS system colors causes layout tests to fail due to screen calibration : [Attachment 25329] Patch v1

[bugzilla-daemon at webkit.org]

Pierre-Olivier Latour <pol at apple.com> has asked  for review:
Bug 22300: Use of NSCalibratedRGBColorSpace for CSS system colors causes layout
tests to fail due to screen calibration
https://bugs.webkit.org/show_bug.cgi?id=22300

Attachment 25329: Patch v1
https://bugs.webkit.org/attachment.cgi?id=25329&action=review

------- Additional Comments from Pierre-Olivier Latour <pol at apple.com>
The way to fix this issue and other potential ones is to ensure WebKit is
always using Device RGB colorspace internally, which is mostly the case today.

Note that I replaced calls to +[NSColor whiteColor] as well since these return
colors in calibrated colorspace.

I ran all layout tests with pixel tests enabled and disabled and no regressions
were reported, except for
platform/mac/fast/text/attributed-substring-from-range-001.html which needs to
be updated.