[webkit-reviews] review requested: [Bug 22390] Abstract away JSC:: usage in WebCore/xml : [Attachment 25328] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 20 18:42:16 PST 2008


Darin Fisher (Google) <darin at chromium.org> has asked  for review:
Bug 22390: Abstract away JSC:: usage in WebCore/xml
https://bugs.webkit.org/show_bug.cgi?id=22390

Attachment 25328: v1 patch
https://bugs.webkit.org/attachment.cgi?id=25328&action=review

------- Additional Comments from Darin Fisher (Google) <darin at chromium.org>
This patch also includes some const fixes to InspectorController that enable
implicit conversion from ScriptString to UString work (and it's just a good
idea to pass these as const references anyways).

I was not able to completely abstract away JSC from XMLHttpRequest, so I moved
a few bits into #if USE(JSC).  Those bits do not need a V8 equivalent.

I decided to change XMLHttpRequest::m_lastSendURL into a WebCore::String since
it is only used as a String.


More information about the webkit-reviews mailing list