[webkit-reviews] review denied: [Bug 22299] Improve visual studio 2008 sp1 compilation : [Attachment 25203] Template fixes

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 22299: Improve visual studio 2008 sp1 compilation
https://bugs.webkit.org/show_bug.cgi?id=22299

Attachment 25203: Template fixes
https://bugs.webkit.org/attachment.cgi?id=25203&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You should set CHANGE_LOG_NAME or REAL_NAME to "Marc-Antoine Ruel" (or just
edit the ChangeLog after the fact to have your real name instead of maruel).

Why add _ to the end of these template parameter names?  That's not WebKit
style, it might be google style, I'm not even sure of that (but that doesn't
really have any bearing here).

Also generally we mention the bug number in the changelog, and it would be nice
for documentations sake to have the text of the warning/error in the bug or the
changelog.  Maciej or Darin (Adler) would be most likely to review this change,
as they're the two template experts in the WebKit community (that I know of).

r- for the reasons mentioned above.