[webkit-reviews] review requested: [Bug 21820] Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME : [Attachment 24934] the fourth proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 17 13:15:58 PST 2008
Alexey Proskuryakov <ap at webkit.org> has asked Justin Garcia
<justin.garcia at apple.com> for review:
Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic
IME
https://bugs.webkit.org/show_bug.cgi?id=21820
Attachment 24934: the fourth proposed fix
https://bugs.webkit.org/attachment.cgi?id=24934&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I suppose that this was meant for review, marking as such.
I don't think that this patch should enable DeleteBackward - that's not as easy
as it looks, because we'd need to check whether its behavior in edge cases
matches other commands, and how it differs from BackwardDelete. Please change
the test to use eventSender (see e.g.
editing/deleting/delete-by-word-001.html). Sorry for misguiding you by giving
an example that uses commands.
I don't have an opinion on the substance of the fix.
More information about the webkit-reviews
mailing list