[webkit-reviews] review granted: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25201] Address Comment 84 for WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 16 15:15:08 PST 2008


Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25201: Address Comment 84 for WebKit
https://bugs.webkit.org/attachment.cgi?id=25201&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    DEFINE_STATIC_LOCAL(RetainPtr<NSArray>, types, ([[NSArray alloc]
initWithObjects:
> +				   WebURLsWithTitlesPboardType,
> +				   NSURLPboardType,
> +				   WebURLPboardType,
> +				   WebURLNamePboardType,
> +				   NSStringPboardType,
> +				   nil]));

I would just indent these type names in four spaces, not so far in, if it was
me

r=me


More information about the webkit-reviews mailing list