[webkit-reviews] review granted: [Bug 21810] Remove use of static C++ objects that are destroyed at exit time (destructors) : [Attachment 25200] Address Comment 83 for WebCore

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 21810: Remove use of static C++ objects that are destroyed at exit time
(destructors)
https://bugs.webkit.org/show_bug.cgi?id=21810

Attachment 25200: Address Comment 83 for WebCore
https://bugs.webkit.org/attachment.cgi?id=25200&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    static RefPtr<BitmapImage> nullImage = BitmapImage::create();
> +    DEFINE_STATIC_LOCAL(RefPtr<BitmapImage>, nullImage,
(BitmapImage::create()));;

Extra semicolon here.

> +static inline SharedBuffer* _createTemplateDocumentData(Settings *settings)

The * should be next to Settings, not "settings".

There's no reason to have a leading underscore in this function name.

The argument here could be the Document rather than the Settings. But it's fine
this way.

> +static inline NSColor* _createPatternColor(NSString* name, NSColor*
defaultColor, bool& usingDot)

There's no reason to have a leading underscore in this function name.

I'm don't think this function should be marked inline.

r=me