[webkit-reviews] review granted: [Bug 22030] Make EventNames usable from multiple threads : [Attachment 24837] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 3 09:12:58 PST 2008

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 22030: Make EventNames usable from multiple threads

Attachment 24837: proposed patch

------- Additional Comments from Darin Adler <darin at apple.com>
Any uses in WebKit outside of the "mac" and "win" directories?

Typo "Atimic" in one place.

What performance impact does this change have?

Why is the EventNames constructor public? Why is "int dummy" a member of
EventNames? Just to allow the initialization macro to work? I think both the
constructor and the dummy member should be private.

> : dummy (0)

There should be a space after the word "dummy" here?

> // Initialization is not thread safe, so this function must be called from
the main thread first.

Why not assert this?


More information about the webkit-reviews mailing list