[webkit-reviews] review granted: [Bug 22041] Fix CURL crashes on the test suite : [Attachment 24851] Fix segfault with setDefersLoading

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 3 09:10:39 PST 2008


Alp Toker <alp at nuanti.com> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 22041: Fix CURL crashes on the test suite
https://bugs.webkit.org/show_bug.cgi?id=22041

Attachment 24851: Fix segfault with setDefersLoading
https://bugs.webkit.org/attachment.cgi?id=24851&action=edit

------- Additional Comments from Alp Toker <alp at nuanti.com>
r=me

Good catch. I didn't spot this when testing recently because I neither had
debugging enabled nor a recent enough version of curl to get the defer code
compiled. Oops!

Extra braces should not be there in the first if case to suit WebKit coding
style. Will fix and land to get this out of the way.


More information about the webkit-reviews mailing list