[webkit-reviews] review cancelled: [Bug 19180] speed up SunSpider by optimizing immediate number cases : [Attachment 21363] Patch for + and -

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 28 02:55:27 PDT 2008

Alexey Proskuryakov <ap at webkit.org> has cancelled 's request for review:
Bug 19180: speed up SunSpider by optimizing immediate number cases

Attachment 21363: Patch for + and -

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Landed this patch, it was a 2% improvement after a slight random change that
should have been a slowdown - I've moved VM_CHECK_EXCEPTION() out of else
block. Applying the same change to bitops regresses performance, though.

On disassembly, I saw a lot of changes everywhere in Machine::executePrivate,
but I can't tell what gcc was thinking. There are also changes in completely
unrelated places, such as base64 encoding and registerThread().

More information about the webkit-reviews mailing list