[webkit-reviews] review denied: [Bug 18704] [gtk] cannot type letters with dead keys in textarea : [Attachment 20780] calls doTextFieldCommandFromEvent on keydown for textareas

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied arno. <arenevier at fdn.fr>'s
request for review:
Bug 18704: [gtk] cannot type letters with dead keys in textarea
http://bugs.webkit.org/show_bug.cgi?id=18704

Attachment 20780: calls doTextFieldCommandFromEvent on keydown for textareas
http://bugs.webkit.org/attachment.cgi?id=20780&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
WebEditorClient::doTextFieldCommandFromEvent() is really only about text
fields, which textareas are not. Invoking it for text areas would break Safari
on the Mac, besides not being true to its name.

We could of course add another client method just for textareas, but processing
dead keys in element default handlers doesn't seem right to me in general, it
is a much lower level task. Perhaps WebEditorClient::handleKeyboardEvent()
would be more appropriate.