[webkit-reviews] review denied: [Bug 19028] Implement CSS Animation (with keyframes, events, interfaces, etc) : [Attachment 21179] Update support for CSS Transforms

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Dean Jackson <dino at apple.com>'s request
for review:
Bug 19028: Implement CSS Animation (with keyframes, events, interfaces, etc)
http://bugs.webkit.org/show_bug.cgi?id=19028

Attachment 21179: Update support for CSS Transforms
http://bugs.webkit.org/attachment.cgi?id=21179&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
In Transform3D.cpp:

+Transform3D &Transform3D::function() {}

Move the & to be with the return value, so:

Transform3D& Transform3D::function() {}

In CodeGeneratorObjC.pm:

I don't understand this:

-    return "CSSValue" if $parent eq "SVGColor";
+    return "CSSValue" if $parent eq "SVGColor" or $parent eq "CSSValueList";

In DerivedSources.make:

     VoidCallback \
+	WebKitCSSTransformValue \
     WheelEvent \

Double-check if tabs are actually used in that file.

I see "KeyframeList" in this patch.  I think that was unintentional.  Can you
remove it?

This is very close to being able to land.  I think I'll be able to r+ it with
one more revision.