[webkit-reviews] review requested: [Bug 14346] CSS parser accepts unexpected { } in declarations : [Attachment 20925] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 2 08:19:17 PDT 2008


Anatoli Papirovski <apapirovski at mac.com> has asked  for review:
Bug 14346: CSS parser accepts unexpected { } in declarations
http://bugs.webkit.org/show_bug.cgi?id=14346

Attachment 20925: patch
http://bugs.webkit.org/attachment.cgi?id=20925&action=edit

------- Additional Comments from Anatoli Papirovski <apapirovski at mac.com>
(One note to begin with, there's hardly any logic to the formatting of the
grammar file, so I just tried to match whatever was there... )

The changelog has most of the fixes listed in it. I'll just provide the test
cases not in our test suite that were fixed by this patch:
http://hixie.ch/tests/adhoc/css/parsing/core-syntax/002-demo.html
http://hixie.ch/tests/adhoc/css/parsing/core-syntax/002.html
http://hixie.ch/tests/adhoc/css/parsing/core-syntax/003.html
http://hixie.ch/tests/adhoc/css/parsing/core-syntax/006.html
http://dbaron.org/css/test/parsing4
http://dbaron.org/css/test/parsing5
http://samples.msdn.microsoft.com/csstestpages/Chapter_4/eof-001.htm
http://samples.msdn.microsoft.com/csstestpages/Chapter_4/invalid-decl-at-rule-0
01.htm (wrong description inside, but a correct test case)
http://annevankesteren.nl/test/css/syntax/007.html
http://annevankesteren.nl/test/css/syntax/018.html

+ the three test cases from the CSS 2.1 test suite which are in LayoutTests.


More information about the webkit-reviews mailing list