[webkit-reviews] review requested: [Bug 18059] squirrelfish needs to compile on platforms without computed goto : [Attachment 20021] First run at the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 24 21:45:35 PDT 2008
Oliver Hunt <oliver at apple.com> has asked for review:
Bug 18059: squirrelfish needs to compile on platforms without computed goto
http://bugs.webkit.org/show_bug.cgi?id=18059
Attachment 20021: First run at the patch
http://bugs.webkit.org/attachment.cgi?id=20021&action=edit
------- Additional Comments from Oliver Hunt <oliver at apple.com>
Formatting of the runloop should be indented one level, but that will screw
anyone with unlanded changes. Also not entirely sure about having the computed
goto conditionalised on the compiler support computed goto -- may be better to
have an explicit (independent) flag later.
More information about the webkit-reviews
mailing list