[webkit-reviews] review denied: [Bug 16440] ER: file replacement support : [Attachment 19876] implemented review comments

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Sajesh
<sajesh.ramachandran at apple.com>'s request for review:
Bug 16440: ER: file replacement support
http://bugs.webkit.org/show_bug.cgi?id=16440

Attachment 19876: implemented review comments
http://bugs.webkit.org/attachment.cgi?id=19876&action=edit

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
This patch will break other platforms, since Frame::currentUserHomeDir() is
only implemented on the Mac. 

I also don't think the current approach will be good enough to ship. Right now
the URL is changed to a localhost URL instead of using the original, this will
break some sites that require cross domain scripting. Also this feature would
be better if it didn't touch the disk and require a local HTTP server running.
This feature should only replace the data that is received from the load, in
memory.