[webkit-reviews] review requested: [Bug 17261] IconRecord::loadImageFromResource is not called from WebCore : [Attachment 19763] Allow the urlIcon to be themable on some ports

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 14 09:56:58 PDT 2008


Holger Freyther <freyther at handhelds.org> has asked  for review:
Bug 17261: IconRecord::loadImageFromResource is not called from WebCore
http://bugs.webkit.org/show_bug.cgi?id=17261

Attachment 19763: Allow the urlIcon to be themable on some ports
http://bugs.webkit.org/attachment.cgi?id=19763&action=edit

------- Additional Comments from Holger Freyther <freyther at handhelds.org>
Okay the Windows code was not completely dead and adam had to back out my
previous commit.

Change the Windows code to ask the iconDatabase() for the urlIcon. I think this
change makes sense as the urlIcon is not themable in the windows platform and
there should be only one urlIcon, I opted for the one in the IconDatabase.cpp.
It would be appreciated if some one with a windows machine could give it a try.


More information about the webkit-reviews mailing list