[webkit-reviews] review granted: [Bug 17133] Should support pausing JavaScript execution without hanging the process : [Attachment 19744] Make most of callOnMainThread be cross-platform

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 17133: Should support pausing JavaScript execution without hanging the
process
http://bugs.webkit.org/show_bug.cgi?id=17133

Attachment 19744: Make most of callOnMainThread be cross-platform
http://bugs.webkit.org/attachment.cgi?id=19744&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

+				RelativePath="..\platform\MainThreadInternal.h"


I'm not sure if I love the file name "MainThreadInternal" - Internal has all
sorts of connotations, which do not apply here :)

I think I'd just keep these functions in the same file, although either way is
OK with me.

-    if (processingCustomThreadingMessage)
-	 LOG(Threading, "callOnMainThread() called recursively.  Beware of
nested PostMessage()s");
+    if (dispatchingCallbacks)
+	 LOG(Threading, "callOnMainThread() called recursively.");

I do not understand this check. What's the problem with a thread making a
callback when the main thread is working through previous ones (possibly from
other threads)? I suggest removing it, if a reason doesn't come up.