[webkit-reviews] review denied: [Bug 17769] WebKit compilation fixes for HP/UX acc : [Attachment 19666] Fix for scoping with broken compilers

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Simon Hausmann <hausmann at kde.org>'s
request for review:
Bug 17769: WebKit compilation fixes for HP/UX acc
http://bugs.webkit.org/show_bug.cgi?id=17769

Attachment 19666: Fix for scoping with broken compilers
http://bugs.webkit.org/attachment.cgi?id=19666&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This workaround does not belong in Platform.h. That file only defines macros to
identify the platform, not workarounds for bugs or anything like that. It
should not be commandeered for this new purpose.

+#if (defined(_MSC_VER) && _MSC_VER-0 < 1300 && !defined(__INTEL_COMPILER)) ||
defined(__sgi) || (defined(__HP_aCC) && defined(__ia64))

This is not how we do things with the Platform.h file. You should be using the
COMPILER() macros defined in there and adding new ones as needed.

This should go in a new header file. There may be some clever way of including
it in all the projects, but adding it to Platform.h is not right.