[webkit-reviews] review denied: [Bug 17769] WebKit compilation fixes for HP/UX acc : [Attachment 19667] Avoid the use of typename with aCC 6

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Simon Hausmann <hausmann at kde.org>'s
request for review:
Bug 17769: WebKit compilation fixes for HP/UX acc
http://bugs.webkit.org/show_bug.cgi?id=17769

Attachment 19667: Avoid the use of typename with aCC 6
http://bugs.webkit.org/attachment.cgi?id=19667&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
This is not correctly using include files. Definitions like this should not be
in Platform.h.

What *should* go in Platform.h is a definition to let us use COMPILER() to
identify the HP compiler.

The actual macro can either go in ListHashSet.h or a new header, but should not
go in Platform.h.

Have you checked to see if you can leave typename out with the other compilers?
Maybe this doesn't require a macro at all?

If it does require a macro, then I don't think WTF_TYPENAME is descriptive
enough. It makes it sound like you have to use this everywhere, when really
it's only for a few specific call sites. The name will probably need to mention
HP specifically.