[webkit-reviews] review granted: [Bug 17640] eliminate WebCoreFrameBridge : [Attachment 19609] patch that moves Java applet loading off the bridge

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 08:37:02 PDT 2008


Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 17640: eliminate WebCoreFrameBridge
http://bugs.webkit.org/show_bug.cgi?id=17640

Attachment 19609: patch that moves Java applet loading off the bridge
http://bugs.webkit.org/attachment.cgi?id=19609&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
I am really not sure what is the correct possition for the * here, but since
the following line has it next to the type, also for an ObjC type, it would be
nice to be consistent.

 #if PLATFORM(MAC)
+	 virtual jobject javaApplet(NSView *) { return 0; }
	  virtual NSCachedURLResponse* willCacheResponse(DocumentLoader*,
unsigned long identifier, NSCachedURLResponse*) const = 0;

r=me


More information about the webkit-reviews mailing list