[webkit-reviews] review granted: [Bug 17732] An external JavaScript, after changing its src attribute, which has not charset declaration in its script tag and encoding info in corresponding http response, can not be correctly decoded. : [Attachment 19634] patch v3, based on patch v2, move method scriptCharset from Document class to HTMLScriptElement class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 08:18:04 PDT 2008


Alexey Proskuryakov <ap at webkit.org> has granted johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 17732: An external JavaScript, after changing its src attribute, which has
not charset declaration in its script tag and encoding info in corresponding
http response, can not be correctly decoded.
http://bugs.webkit.org/show_bug.cgi?id=17732

Attachment 19634: patch v3, based on patch v2, move method scriptCharset from
Document class to HTMLScriptElement class
http://bugs.webkit.org/attachment.cgi?id=19634&action=edit

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

I'm going to tweak wording of some comments a bit when landing.


More information about the webkit-reviews mailing list