[webkit-reviews] review granted: [Bug 19747] Merge inc/dec halves of PrefixDotNode and PostfixDotNode : [Attachment 21906] Patch to merge inc/dec halves of PrefixDotNode and PostfixDotNode
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 24 20:35:42 PDT 2008
Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 19747: Merge inc/dec halves of PrefixDotNode and PostfixDotNode
https://bugs.webkit.org/show_bug.cgi?id=19747
Attachment 21906: Patch to merge inc/dec halves of PrefixDotNode and
PostfixDotNode
https://bugs.webkit.org/attachment.cgi?id=21906&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
Nice job! A couple of nits on style.
Some white space issue here.
+ virtual RegisterID* emitCode(CodeGenerator&, RegisterID* = 0)
KJS_FAST_CALL;
+ virtual void streamTo(SourceStream&) const KJS_FAST_CALL;
Here too.
+ Operator m_operator;
+ };
r=me if you fix those issues.
More information about the webkit-reviews
mailing list