[webkit-reviews] review requested: [Bug 19290] More patches not handled by PrettyPatch.rb : [Attachment 21918] Fix remaining patches v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 24 17:35:32 PDT 2008

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 19290: More patches not handled by PrettyPatch.rb

Attachment 21918: Fix remaining patches v2

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #17)
> (From update of attachment 21469 [edit])
> I wonder if we should just always look for the "---" and "+++" lines instead
> looking for "Index:" or "diff --git" lines? I think that's what the patch
> utility does anyway. It seems like it would simplify this code quite a bit.
> Care to take a stab at that, Dave?

I don't think ignoring the "Index:" and "diff --git" lines will work.  There
are some patches with an "Index:" line that don't have "---" or "+++" lines
(like binary patches), so this approach won't work with those cases.

I did manage to simplify the patch from the previous attempt, at least for the
first two changes.

More information about the webkit-reviews mailing list