[webkit-reviews] review granted: [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports : [Attachment 21891] Updated patch: use local, fix build failure in Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 14:34:43 PDT 2008


Darin Adler <darin at apple.com> has granted Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19727: Return bool from GraphicsContext::getShadow() so the tests aren't
duplicated so many times in Cairo and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=19727

Attachment 21891: Updated patch: use local, fix build failure in Qt
https://bugs.webkit.org/attachment.cgi?id=21891&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Please don't check in your ChangeLog with:

	 WARNING: NO TEST CASES ADDED OR CHANGED

Please add an entry to the ChangeLog with the bug number in it and a summary
description of the changes.

Code changes still good. r=me


More information about the webkit-reviews mailing list