[webkit-reviews] review requested: [Bug 19727] Return bool from GraphicsContext::getShadow() so the tests aren't duplicated so many times in Cairo and Qt ports : [Attachment 21891] Updated patch: use local, fix build failure in Qt

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 23 14:33:00 PDT 2008


Jonathon Jongsma <jonathon.jongsma at collabora.co.uk> has asked Darin Adler
<darin at apple.com> for review:
Bug 19727: Return bool from GraphicsContext::getShadow() so the tests aren't
duplicated so many times in Cairo and Qt ports
https://bugs.webkit.org/show_bug.cgi?id=19727

Attachment 21891: Updated patch: use local, fix build failure in Qt
https://bugs.webkit.org/attachment.cgi?id=21891&action=edit

------- Additional Comments from Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>
in fact, I need to submit an updated patch anyway since I accidentally moved a
variable out of scope and broke compilation for the Qt port.  Sorry for all of
the noise.  Hopefully this one is final.


More information about the webkit-reviews mailing list