[webkit-reviews] review cancelled: [Bug 12425] border-radius not applied to fieldset with legend : [Attachment 21812] Implements border radius logic for a fieldset, based off RenderObject's implementation

[bugzilla-daemon at webkit.org]

Alex Taylor <darwin at milliamp.org> has cancelled Alex Taylor
<darwin at milliamp.org>'s request for review:
Bug 12425: border-radius not applied to fieldset with legend
https://bugs.webkit.org/show_bug.cgi?id=12425

Attachment 21812: Implements border radius logic for a fieldset, based off
RenderObject's implementation
https://bugs.webkit.org/attachment.cgi?id=21812&action=edit

------- Additional Comments from Alex Taylor <darwin at milliamp.org>
This patch uses the alternate way of clipping the legend. It clips the region
where they legend will be displayed. 

This keeps the rendering consistent with the current case where there are no
border radii but adds support but calling the parent's "paintBoxDecorations"
method to follow the default code path but with a clipping region attached.

This uses a lot less code than the current way of drawing the pieces around the
legend and trying to not draw over the top of it. It also prevents code
duplication between drawing borders for a fieldset and for a generic object. 

As a side note, testing showed that this is consistent with how Firefox handles
the border radius + legend case on a fieldset.