[webkit-reviews] review requested: [Bug 14360] JavaScript source view should be syntax highlighted : [Attachment 21820] lines reduced

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 10:47:23 PDT 2008

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 14360: JavaScript source view should be syntax highlighted

Attachment 21820: lines reduced

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
Thanks aroben. I was feeling there was too much redundancy.
I reduced the number of lines to less than half the previous one. I hope I
didn't compromise code readability. I was surprised to see that generating a
function every time has hardly any overhead.

More information about the webkit-reviews mailing list