[webkit-reviews] review cancelled: [Bug 14360] JavaScript source view should be syntax highlighted : [Attachment 21811] regexp detection improved

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 18 10:47:22 PDT 2008


Keishi Hattori <casey.hattori at gmail.com> has cancelled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 14360: JavaScript source view should be syntax highlighted
https://bugs.webkit.org/show_bug.cgi?id=14360

Attachment 21811: regexp detection improved
https://bugs.webkit.org/attachment.cgi?id=21811&action=edit

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
Thanks aroben. I was feeling there was too much redundancy.
I reduced the number of lines to less than half the previous one. I hope I
didn't compromise code readability. I was surprised to see that generating a
function every time has hardly any overhead.


More information about the webkit-reviews mailing list