[webkit-reviews] review granted: [Bug 19583] Use tabIndex in the Web Inspector for focusable areas : [Attachment 21737] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 17 13:50:14 PDT 2008

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 19583: Use tabIndex in the Web Inspector for focusable areas

Attachment 21737: Proposed patch

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
-	 if (WebInspector.currentFocusElement === this.messagesElement)
-	     WebInspector.currentFocusElement = this._previousFocusElement;
-	 delete this._previousFocusElement;
+	 if (this.element === WebInspector.currentFocusElement ||
+	     WebInspector.currentFocusElement =

This seems like a change in behavior. You do a similar check at the end of this
patch. Can you explain it in the ChangeLog?


More information about the webkit-reviews mailing list