[webkit-reviews] review granted: [Bug 19583] Use tabIndex in the Web Inspector for focusable areas : [Attachment 21737] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 19583: Use tabIndex in the Web Inspector for focusable areas
https://bugs.webkit.org/show_bug.cgi?id=19583

Attachment 21737: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=21737&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
-	 if (WebInspector.currentFocusElement === this.messagesElement)
-	     WebInspector.currentFocusElement = this._previousFocusElement;
-	 delete this._previousFocusElement;
+	 if (this.element === WebInspector.currentFocusElement ||
this.element.isAncestor(WebInspector.currentFocusElement))
+	     WebInspector.currentFocusElement =
WebInspector.previousFocusElement;

This seems like a change in behavior. You do a similar check at the end of this
patch. Can you explain it in the ChangeLog?

r=me