[webkit-reviews] review granted: [Bug 19586] Show the file and line in the call frame next to the function name : [Attachment 21733] Proposed patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Timothy Hatcher
<timothy at hatcher.name>'s request for review:
Bug 19586: Show the file and line in the call frame next to the function name
https://bugs.webkit.org/show_bug.cgi?id=19586

Attachment 21733: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=21733&action=edit

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
+	     if (scriptOrResource instanceof WebInspector.Script)
+		 subtitle =
WebInspector.displayNameForURL(scriptOrResource.sourceURL);
+	     else if (scriptOrResource instanceof WebInspector.Resource)
+		 subtitle =
WebInspector.displayNameForURL(scriptOrResource.url);

You could probably do this instead:

subtitle = WebInspector.displayNameForURL(scriptOrResource.sourceURL ||
scriptOrResource.url)

Or we could make Scripts and Resources use the same property for their URL.

r=me