[webkit-reviews] review denied: [Bug 19422] Distinct redirects from the same link do not create distinct history items : [Attachment 21615] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 10:10:16 PDT 2008


Brady Eidson <beidson at apple.com> has denied Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 19422: Distinct redirects from the same link do not create distinct history
items
https://bugs.webkit.org/show_bug.cgi?id=19422

Attachment 21615: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=21615&action=edit

------- Additional Comments from Brady Eidson <beidson at apple.com>
So, I *think* this might break history with certain types of redirect chains.

Imagine visiting URL A, which redirects to URL B, which redirects back to A. 
With this patch, I think the single navigation would result in 2 history items,
which isn't correct.

I discussed this with Cameron on irc, and I he's trying to write a test to
replicate my theoretical scenario


More information about the webkit-reviews mailing list