[webkit-reviews] review granted: [Bug 19457] Create fused opcodes for tests and conditional jumps : [Attachment 21613] Revised proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 11 11:57:40 PDT 2008


Darin Adler <darin at apple.com> has granted Cameron Zwarich (cpst)
<cwzwarich at uwaterloo.ca>'s request for review:
Bug 19457: Create fused opcodes for tests and conditional jumps
https://bugs.webkit.org/show_bug.cgi?id=19457

Attachment 21613: Revised proposed patch
https://bugs.webkit.org/attachment.cgi?id=21613&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
 395 void CodeGenerator::retrieveLastBinaryOp(int& dstIndex, int& src1Index,
int& src2Index)
 396 {
 397	 size_t size = instructions().size();
 398	 dstIndex = instructions().at(size - 3).u.operand;
 399	 src1Index = instructions().at(size - 2).u.operand;
 400	 src2Index = instructions().at(size - 1).u.operand;
 401 }

This should assert that size is >= 4.

 405	 instructions().shrink(instructions().size() - 4);

 403 void CodeGenerator::rewindBinaryOp()
 404 {
 405	 instructions().shrink(instructions().size() - 4);
 406 }

This too.

r=me


More information about the webkit-reviews mailing list