[webkit-reviews] review denied: [Bug 18996] Build of WebKit Qt fails on Linux due to .pri file problem. : [Attachment 21220] Patch for pcre.pri to remove independent compilation of chartables.c

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Clemmitt Sigler
<cmsigler at gmail.com>'s request for review:
Bug 18996: Build of WebKit Qt fails on Linux due to .pri file problem.
http://bugs.webkit.org/show_bug.cgi?id=18996

Attachment 21220: Patch for pcre.pri to remove independent compilation of
chartables.c
http://bugs.webkit.org/attachment.cgi?id=21220&action=edit

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I'm sorry, this patch looks wrong to me. The purpose of this rule in pcre.pri
is to _generate_ chartables.c, so it can be included from pcre_tables.c.
Without this rule in a clean build environment chartables.c is not generated at
all. Could it be that you have a stable chartables.c somewhere? Or did you
perhaps modify some other file so that the file is generated twice for you? Can
you check the generated Makefile for traces of chartables.c after you have
applied your patch?