[webkit-reviews] review denied: [Bug 19331] Drag and drop of links in edit mode violates assert in MoveSelectionCommand::doApply() : [Attachment 21484] An alternate patch that uses the enclosingAnchorElement() function from htmlediting.h instead of traversing the heirarchy manually

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 3 21:06:41 PDT 2008


Oliver Hunt <oliver at apple.com> has denied Jonathon Jongsma
<jonathon.jongsma at collabora.co.uk>'s request for review:
Bug 19331: Drag and drop of links in edit mode violates assert in
MoveSelectionCommand::doApply()
http://bugs.webkit.org/show_bug.cgi?id=19331

Attachment 21484: An alternate patch that uses the enclosingAnchorElement()
function from htmlediting.h instead of traversing the heirarchy manually
http://bugs.webkit.org/attachment.cgi?id=21484&action=edit

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Any fix for this bug, whether it's valid or not, should be at the drag launch
site, not the receiver.  Eg. If the drag is starting inside a link, and the
correct link mode is set, then the caret should be converted to a range
containing that link.


More information about the webkit-reviews mailing list