[webkit-reviews] review denied: [Bug 20173] wx port does not show tooltips : [Attachment 22481] implement ChromeClientWx::setToolTip

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Kevin Watters
<kevinwatters at gmail.com>'s request for review:
Bug 20173: wx port does not show tooltips
https://bugs.webkit.org/show_bug.cgi?id=20173

Attachment 22481: implement ChromeClientWx::setToolTip
https://bugs.webkit.org/attachment.cgi?id=22481&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine except for the tabs.  WebCore uses 4 spaces, not tabs.

Also, which way is the easier conversion?

+	if (!tooltip || tooltip->GetTip() != wxString(tip))
+		m_webView->SetToolTip(tip);

>From wxString to String or the other way?  I'm surprised that you need the
explicit wxString conversion there at all.

Since you don't have the ability to commit your own patches (yet), please
upload a new patch without tabs.

Thanks!